Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] Update all of rails: 5.2.4.2 β†’ 5.2.4.3 (patch) #445

Merged
merged 1 commit into from
May 18, 2020

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented May 18, 2020


🚨 Your version of activestorage has known security vulnerabilities 🚨

Advisory: CVE-2020-8162
Disclosed: May 18, 2020
URL: https://groups.google.com/forum/#!topic/rubyonrails-security/PjU3946mreQ

Circumvention of file size limits in ActiveStorage

There is a vulnerability in ActiveStorage's S3 adapter that allows the Content-Length of a
direct file upload to be modified by an end user.

Versions Affected: rails < 5.2.4.2, rails < 6.0.3.1
Not affected: Applications that do not use the direct upload functionality of the ActiveStorage S3 adapter.
Fixed Versions: rails >= 5.2.4.3, rails >= 6.0.3.1

Impact

Utilizing this vulnerability, an attacker can control the Content-Length of an S3 direct upload URL without receiving a
new signature from the server. This could be used to bypass controls in place on the server to limit upload size.

Workarounds

This is a low-severity security issue. As such, no workaround is necessarily
until such time as the application can be upgraded.


🚨 We recommend to merge and deploy this update as soon as possible! 🚨

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rails (5.2.4.2 β†’ 5.2.4.3) Β· Repo

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ actioncable (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ actionmailer (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ actionpack (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ actionview (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ activejob (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ activemodel (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ activerecord (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ activestorage (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

↗️ activesupport (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ loofah (indirect, 2.4.0 β†’ 2.5.0) Β· Repo Β· Changelog

Release Notes

2.5.0 (from changelog)

Features

  • Allow more CSS length units: "ch", "vw", "vh", "Q", "lh", "vmin", "vmax". [#178] (Thanks, @JuanitoFatas!)

Fixes

  • Remove comments from Loofah::HTML::Documents that exist outside the html element. [#80]

Other changes

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 21 commits:

↗️ mimemagic (indirect, 0.3.4 β†’ 0.3.5) Β· Repo Β· Changelog

Release Notes

0.3.5 (from changelog)

Mimetype extensions are now ordered by freedesktop.org's priority

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 2 commits:

↗️ minitest (indirect, 5.14.0 β†’ 5.14.1) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 6 commits:

↗️ railties (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label May 18, 2020
@gravesm gravesm temporarily deployed to library-thesis-dropbox--pr-445 May 18, 2020 18:20 Inactive
@github-actions
Copy link

Coverage Status

Coverage remained the same at 92.386% when pulling c30757d on depfu/update/group/rails-5.2.4.3 into 3c51dec on master.

@jazairi
Copy link
Contributor

jazairi commented May 18, 2020

@depfu rebase

@jazairi jazairi merged commit c64b067 into master May 18, 2020
@depfu depfu bot deleted the depfu/update/group/rails-5.2.4.3 branch May 18, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants