Implement transfer receipt email #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-bernhardt
force-pushed
the
etd-79-transfer-success-email
branch
from
a937cd1 to
c8cd60d
Compare
** Why are these changes being introduced: * Staff who submit batches of thesis files to the Libraries as a bulk Transfer record should receive an email confirming their receipt. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/ETD-79 ** How does this address that need: * This adds a transfer_receipt_email method to the ReceiptMailer class, with an associated view template and tests. ** Document any side effects to this change: * It may be a good idea to update the name of the thesis receipt method to something specific to theses. Right now the ReceiptMailer class has two methods: receipt_email (for theses) and transfer_receipt_email (for transfers). * The testing approach for this email is slightly different than what we use for the thesis email. This is intentional, and the result of some difficulty. Future-us may take another pass at it, perhaps.
matt-bernhardt
force-pushed
the
etd-79-transfer-success-email
branch
from
8f1a077 to
8424292
Compare
JPrevost
approved these changes
Apr 15, 2021
| @@ -0,0 +1,23 @@ | |||
| <p>Hello <%= @user.given_name %>,</p> | |||
There was a problem hiding this comment.
Ugh, why do we continue to insist on using names when they aren't necessary :|
| @@ -7,4 +7,13 @@ def receipt_email(thesis, user) | |||
| to: @user.email, | |||
| subject: 'Your thesis information submission') | |||
| end | |||
|
|
|||
| def transfer_receipt_email(transfer, user) | |||
| return unless ENV.fetch('DISABLE_ALL_EMAIL', 'true') == 'false' # allows PR builds to disable emails | |||
There was a problem hiding this comment.
I know this logic works and is the same in the other mailer so I'm not suggesting we change it... but also it hurts my brain.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the transfer success email, with associated tests.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO