Address transfer submission process based on user feedback #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-bernhardt
force-pushed
the
etd-256-transfer-punchlist
branch
from
f480724 to
df59af1
Compare
matt-bernhardt
requested review from
JPrevost and
jazairi
and removed request for
JPrevost
JPrevost
reviewed
Apr 27, 2021
There was a problem hiding this comment.
I confirmed voice over does read the changing part but then just abruptly moved to complete. That's probably okay, but wanted to note that it was pretty janky still but I think it's likely very good for slower uploads and just acts weird for a bunch of small files.
I might have missed the new visual indicators if I didn't know to scroll to see them as they were just off the bottom of my screen. It might be good to change focus? Not sure. Thoughts?
matt-bernhardt
force-pushed
the
etd-256-transfer-punchlist
branch
from
df59af1 to
2be2305
Compare
** Why are these changes being introduced: * The default rendering of in-progress uploads to S3 (provided by boilerplate code around direct upload) is inaccessible to screen readers, and is visually indistinct. * Some of the wording on the new transfer form needs to be adjusted based on the results of user testing, and the subsequent changes. * A link to DSpace@MIT needs to be added to the Transfer confirmation page. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/ETD-256 ** How does this address that need: This updates the JS and CSS used to render the direct upload progress indicators. Specific changes include: * Moving the upload panel to be visually just above the form submit button, which reduces the chance that the user will miss them (being off-screen in the middle of the form). Additionally, the upload process will set the URL hash to this newly-created panel in case it should appear offscreen. * Adds an ARIA live region at the top of the panel that provides a summary of the upload process which can be read by screen readers. The panel updates as each file is uploaded. * Applies our branding package to the individual file panels, making them more visually prominent. Beyond the file upload feedback, we also make the following changes: * Updates the form display to take the full width of the content column. * Re-writes the text that appears in the well above the form based on UX-provided copy. ** Document any side effects to this change: * We had already made changes to the boilerplate JS and CSS, but this PR will intervene more heavily. I compared our current file (which we added to the repo some time ago) with the version in the current documentation, and it does not seem to have been updated in the years since - so there appears to be little risk in us needing to implement subsequent changes.
matt-bernhardt
force-pushed
the
etd-256-transfer-punchlist
branch
from
2be2305 to
6e8e336
Compare
|
Ok, I've put up an updated commit that incorporates the feedback from you and Rich, and the conversations that I've had with you and Stephanie. This PR now includes both the changes to the upload progress, as well as the wording changes from Stephanie. |
JPrevost
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://mitlibraries.atlassian.net/browse/ETD-283
Developer
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO