Updates to Transfer and Thesis forms #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** Why are these changes being introduced: * QA and ATIC review has surfaced a small number of needed adjustments to the thesis and transfer forms. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/ETD-286 * https://mitlibraries.atlassian.net/browse/ETD-283 ** How does this address that need: * Updates the field name for supervisors on the thesis form to improve a11y and clarity * Updates content of the content above the Transfer form, fixing two links * Updates the styling of that one content well with some local styles. This is a stop-gap measure until we revisit the drag-and-drop upload UI, at which point that content will hopefully become shorter. ** Document any side effects to this change: * It is generally not recommended to have inline style blocks like this uses, but in context of this being a temporary block of content, it feels more acceptable.
JPrevost
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few UI adjustments based on testing and QA feedback.
Relevant ticket(s):
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO