Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DSpace handle to thesis model #706

Merged
merged 1 commit into from
May 17, 2021

Conversation

hakbailey
Copy link
Contributor

@hakbailey hakbailey commented May 13, 2021

Why these changes are being introduced:

When theses are published to DSpace, the SWORD submission will return a handle that we want to store in this system.

How this addresses that need:

  • Adds dspace_handle field to the thesis model with corresponding test
  • Adds dspace_handle field to admin view of thesis info (note, does not add this field to the edit form, as it is not intended to be edited other than by the SWORD submission job)

Relevant ticket(s):

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

YES

Includes new or updated dependencies?

NO

Why these changes are being introduced:
When theses are published to DSpace, the SWORD submission
will return a handle that we want to store in this system.

How this addresses that need:
* Adds dspace_handle field to the thesis model with corresponding test
* Adds dspace_handle field to admin view of thesis info (note, does
  not add this field to the edit form, as it is not intended to be
  edited other than by the SWORD submission job)

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/ETD-296
@mitlib mitlib temporarily deployed to thesis-submit-pr-706 May 13, 2021 14:38 Inactive
@hakbailey hakbailey requested review from matt-bernhardt, JPrevost and jazairi and removed request for matt-bernhardt and JPrevost May 13, 2021 14:39
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.574% when pulling e637cda on etd-296-add-dspace-handle-to-thesis into be47933 on main.

@JPrevost JPrevost self-assigned this May 13, 2021
@hakbailey hakbailey merged commit dadb07d into main May 17, 2021
@hakbailey hakbailey deleted the etd-296-add-dspace-handle-to-thesis branch May 17, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants