Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses punchlist items #716

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

matt-bernhardt
Copy link
Member

@matt-bernhardt matt-bernhardt commented Jun 1, 2021

There are a few requested changes that have been identified via user testing of the transfer form and processing workflow. This PR attempts to address those items.

Tickets:
https://mitlibraries.atlassian.net/browse/ETD-339
https://mitlibraries.atlassian.net/browse/ETD-340

The first commit in this PR addresses the items in ETD-339, the second commit responds to ETD-340.

I've opted not to write a full blown PR message thus far, but can if that's desired.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

@mitlib mitlib temporarily deployed to thesis-submit-pr-716 June 1, 2021 20:21 Inactive
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.381% when pulling 601418e on etd-339-transfer-processing-punchlist into 4d91a7b on main.

@JPrevost JPrevost self-assigned this Jun 2, 2021
@matt-bernhardt matt-bernhardt merged commit b8b0847 into main Jun 2, 2021
@matt-bernhardt matt-bernhardt deleted the etd-339-transfer-processing-punchlist branch June 2, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants