Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds an issues_found column to thesis queue #739

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Adds an issues_found column to thesis queue #739

merged 1 commit into from
Jul 13, 2021

Conversation

matt-bernhardt
Copy link
Member

@matt-bernhardt matt-bernhardt commented Jul 13, 2021 •
edited by jazairi
Loading

This adds the issues_found field to the thesis processing queue, and
renders the boolean value as "Yes" or "No" for legibility.

Relevant ticket(s):

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

@matt-bernhardt
Adds an issues_found column to thesis queue
cba93a5 
** Why are these changes being introduced:

* Processing staff need to be able to focus on thesis records which have
  already been flagged as having issues. The flag exists in the data but
  is not yet surfaced in the thesis processing queue.

** Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/ETD-373

** How does this address that need:

* This adds the issues_found field to the thesis processing queue, and
  renders the boolean value as "Yes" or "No" for legibility.

** Document any side effects to this change:

* The javascript that populates and interacts with the status filter
  buttons has been adjusted, because that column is now in a different
  location in the data.
@mitlib mitlib temporarily deployed to thesis-submit-pr-739 July 13, 2021 14:17 Inactive
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.755% when pulling cba93a5 on etd-373-filter-by-issues-found into 0cb6306 on main.

@jazairi jazairi self-assigned this Jul 13, 2021
jazairi
jazairi approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing the issues found column, and the correct value displays depending on whether a thesis has issues or not. :shipit:

@matt-bernhardt matt-bernhardt merged commit 25e8948 into main Jul 13, 2021
@matt-bernhardt matt-bernhardt deleted the etd-373-filter-by-issues-found branch July 13, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazairi jazairi jazairi approved these changes

@JPrevost JPrevost Awaiting requested review from JPrevost

Assignees

@jazairi jazairi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matt-bernhardt @coveralls @jazairi @mitlib