Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct DSS JSON #781

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Construct DSS JSON #781

merged 1 commit into from
Sep 17, 2021

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Sep 13, 2021

Why these changes are being introduced:

We want to be able to publish theses to DSpace, which requires
us to convert relevant thesis metadata to DSS-compliant JSON.

Relevant ticket(s):

How this addresses that need:

This creates the requisite submission metadata for DSS, based on the
submission message spec and the data mappings spreadsheet. It does not
save said metadata to AWS, nor does it write messages to the queue.
I'm open to including that work in the same PR, but this seeemed like
a logical breakpoint.

Side effects of this change:

There are fields that are required for publication that are not
validated anywhere in the application. The current process is for
Jess to confirm these as part of their workflow, but we should make
their life easier by including an automated check as part of
the publication status update workflow. A ticket for this work is
open here: https://mitlibraries.atlassian.net/browse/ETD-431

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

@mitlib mitlib temporarily deployed to thesis-submit-pr-781 September 13, 2021 21:04 Inactive
@coveralls
Copy link

coveralls commented Sep 13, 2021

Coverage Status

Coverage increased (+0.2%) to 95.087% when pulling 4bd4a37 on etd-394-construct-dss-json into 22f65ee on main.

@JPrevost JPrevost self-assigned this Sep 14, 2021
@JPrevost JPrevost temporarily deployed to thesis-submit-pr-781 September 14, 2021 16:07 Inactive
@jazairi jazairi temporarily deployed to thesis-submit-pr-781 September 15, 2021 15:49 Inactive
@jazairi jazairi temporarily deployed to thesis-submit-pr-781 September 16, 2021 20:07 Inactive
@jazairi jazairi temporarily deployed to thesis-submit-pr-781 September 16, 2021 20:14 Inactive
@jazairi jazairi temporarily deployed to thesis-submit-pr-781 September 16, 2021 20:30 Inactive
@jazairi jazairi temporarily deployed to thesis-submit-pr-781 September 16, 2021 20:34 Inactive
@jazairi jazairi temporarily deployed to thesis-submit-pr-781 September 16, 2021 20:43 Inactive
@jazairi jazairi temporarily deployed to thesis-submit-pr-781 September 17, 2021 15:18 Inactive
Why these changes are being introduced:

We want to be able to publish theses to DSpace, which requires
us to convert relevant thesis metadata to DSS-compliant JSON.

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/ETD-394

How this addresses that need:

This creates the requisite submission metadata for DSS, based on the
submission message spec and the data mappings spreadsheet. It does not
save said metadata to AWS, nor does it write messages to the queue.

Side effects of this change:

There are fields that are required for publication that are not
validated anywhere in the application. The current process is for
Jess to confirm these as part of their workflow, but we should make
their life easier by including an automated check as part of
the publication status update workflow. A ticket for this work is
open here: https://mitlibraries.atlassian.net/browse/ETD-431

Co-Authored-By: Jeremy Prevost <jprevost@mit.edu>
@jazairi jazairi force-pushed the etd-394-construct-dss-json branch from 3a5ae95 to 4bd4a37 Compare September 17, 2021 20:44
@jazairi jazairi temporarily deployed to thesis-submit-pr-781 September 17, 2021 20:44 Inactive
@jazairi jazairi merged commit d2fb54f into main Sep 17, 2021
@jazairi jazairi deleted the etd-394-construct-dss-json branch September 17, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants