Adds report for thesis files with no defined purpose #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-bernhardt
force-pushed
the
etd-418-files-without-purpose
branch
from
9daa653 to
d6019c6
Compare
matt-bernhardt
force-pushed
the
etd-418-files-without-purpose
branch
from
d6019c6 to
59c4bb7
Compare
matt-bernhardt
force-pushed
the
etd-418-files-without-purpose
branch
from
59c4bb7 to
a0299a3
Compare
** Why are these changes being introduced: * Staff users need a way to confirm that all files attached to theses have had their purpose identified. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/etd-418 ** How does this address that need: * This creates a new report page, /report/files, which lists all files which have no defined value in their purpose field. The page can be filtered by academic term. Entries appear on this report with a link back to the processing form for that thesis, so that staff can assign a purpose for them. ** Document any side effects to this change: * The tests for this report end up repeating a setup method, attach_files, which was written first for the thesis tests. This repetition is not ideal, but IMO necessary. * The implementation for this report is slightly different than other reports, in that the controller calls the specific list method directly, rather than receiving a collection of lists. This makes the template more bound to this given list, rather than having a generic list partial.
matt-bernhardt
force-pushed
the
etd-418-files-without-purpose
branch
from
a0299a3 to
889f2fa
Compare
JPrevost
approved these changes
Oct 4, 2021
| @@ -6,6 +6,14 @@ class ReportController < ApplicationController | |||
|
|
|||
| include ThesisHelper | |||
|
|
|||
| def files | |||
There was a problem hiding this comment.
We may want to consider a more explicit name for this. In the future looking at this method it won't be clear that this is really for the files_with_no_defined_purpose versus some generic files route without having to poke around further.
There was a problem hiding this comment.
This is fair, but I'd like to move this to a different name once we have an idea of what the alternative report is going to be. Looking at the current reporting epic in Jira, no other requested report seems likely to overlap with this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new report page for files with no defined purpose. The table includes links to the processing form for that thesis, so staff can assign a purpose.
More details in the commit message...
Ticket
https://mitlibraries.atlassian.net/browse/ETD-418
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO