Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rubysaml #895

Merged
merged 1 commit into from
Feb 7, 2022
Merged

update rubysaml #895

merged 1 commit into from
Feb 7, 2022

Conversation

JPrevost
Copy link
Member

@JPrevost JPrevost commented Feb 7, 2022

This resolves an error we were seeing in staging. It is unclear why the problem only started showing up on staging when we added a different dependency, but it seems to so 🤷🏻

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

YES

@mitlib mitlib temporarily deployed to thesis-submit-pr-895 February 7, 2022 14:39 Inactive
@JPrevost JPrevost merged commit 8feecda into main Feb 7, 2022
@JPrevost JPrevost deleted the update_rubysaml branch February 7, 2022 14:50
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.044% when pulling 4f9307f on update_rubysaml into 6b967b4 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants