Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show count of preserved theses in publication results email #898

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Feb 9, 2022

Why these changes are being introduced:

The publication results email shows the full array of preserved
thesis. It should show the total count instead.

Relevant ticket(s):

N/A.

How this addresses that need:

This changes the publication results email view to render the count
of preserved theses.

Side effects of this change:

None.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

@mitlib mitlib temporarily deployed to thesis-submit-pr-898 February 9, 2022 21:06 Inactive
@jazairi jazairi temporarily deployed to thesis-submit-pr-898 February 9, 2022 21:19 Inactive
@coveralls
Copy link

coveralls commented Feb 9, 2022

Coverage Status

Coverage remained the same at 97.047% when pulling 175a8f0 on fix-pub-results-email into a069d54 on main.

Why these changes are being introduced:

The publication results email shows the full array of preserved
thesis. It should show the total count instead.

Relevant ticket(s):

N/A.

How this addresses that need:

This changes the publication results email view to render the count
of preserved theses.

Side effects of this change:

None.
@jazairi jazairi force-pushed the fix-pub-results-email branch from a7bff54 to 175a8f0 Compare February 10, 2022 14:15
@jazairi jazairi temporarily deployed to thesis-submit-pr-898 February 10, 2022 14:15 Inactive
@jazairi jazairi merged commit a3cf8b7 into main Feb 10, 2022
@jazairi jazairi deleted the fix-pub-results-email branch February 10, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants