Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add term filter to summary of authors_not_graduated data #930

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Mar 10, 2022

Why these changes are being introduced:

Report#data_authors_not_graduated does not include a grad_date filter,
so all theses with ungraduated authors are shown for each term
instead of just the theses for the corresponding term.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/ETD-429

How this addresses that need:

This adds the term filter into Report#data_authors_not_graduated

Side effects of this change:

N/A.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

@mitlib mitlib temporarily deployed to thesis-submit-pr-930 March 10, 2022 13:26 Inactive
@coveralls
Copy link

coveralls commented Mar 10, 2022

Coverage Status

Coverage decreased (-0.002%) to 97.17% when pulling f5b59a0 on etd-429-author-not-graduated into f6f6a28 on main.

@jazairi jazairi force-pushed the etd-429-author-not-graduated branch from 4d025dc to d3137d7 Compare March 10, 2022 13:33
@jazairi jazairi temporarily deployed to thesis-submit-pr-930 March 10, 2022 13:33 Inactive
@jazairi
Copy link
Contributor Author

jazairi commented Mar 10, 2022

I'm not sure how coverage drops when adding a test, but I wonder if it's because the number of lines changed in Report#data_authors_not_graduated.

Why these changes are being introduced:

Report#data_authors_not_graduated does not include a grad_date filter,
so all theses with ungraduated authors are shown for each term
instead of just the theses for the corresponding term.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/ETD-429

How this addresses that need:

This adds the term filter into Report#data_authors_not_graduated.

Side effects of this change:

N/A.
@jazairi jazairi force-pushed the etd-429-author-not-graduated branch from d3137d7 to f5b59a0 Compare March 10, 2022 16:14
@jazairi jazairi temporarily deployed to thesis-submit-pr-930 March 10, 2022 16:15 Inactive
@jazairi jazairi merged commit f62093c into main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants