Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup authors not graduated summary data #932

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Mar 10, 2022

Why these changes are being introduced:

Theses with multiple files are being counted for each attached
file in the authors not graduated summary data.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/ETD-429

How this addresses that need:

This dedups theses to fix the count in the Report index.

Side effects of this change:

N/A.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

Why these changes are being introduced:

Theses with multiple files are being counted for each attached
file in the authors not graduated summary data.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/ETD-429

How this addresses that need:

This dedups theses to fix the count in the Report index.

Side effects of this change:

N/A.
@mitlib mitlib temporarily deployed to thesis-submit-pr-932 March 10, 2022 19:58 Inactive
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.17% when pulling 2fab76c on etd-429-author-not-graduated into f62093c on main.

@jazairi jazairi merged commit 01fce6b into main Mar 14, 2022
@jazairi jazairi deleted the etd-429-author-not-graduated branch March 14, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants