read_variable_2d in horizontal remapping #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch extends the `read_variable` interface to include 2d array support, in order to facilitate domainless I/O via netCDF calls. This is far from the best implementation (e.g. read_variable_2d introduces another `broadcast` alongside the original one in the horizontal regridding) but it addresses the immediate issues with `MOM_read_data()`.
Codecov Report
@@ Coverage Diff @@
## hor_regrid #14 +/- ##
===========================================
Coverage 29.21% 29.22%
===========================================
Files 239 239
Lines 71604 71625 +21
===========================================
+ Hits 20918 20930 +12
- Misses 50686 50695 +9
Continue to review full report at Codecov.
|
|
Matt, if you're OK with this PR then I can delete and re-fork my repository. Not urgent though, just seeing if you had a chance to review. |
|
As we discussed, I'll move this back to my repo and submit to NOAA-GFDL on your behalf. |
|
Thanks for your help on this issue @marshallward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the
read_variableinterface to include 2d arraysupport, in order to facilitate domainless I/O via netCDF calls.
This is far from the best implementation (e.g. read_variable_2d
introduces another
broadcastalongside the original one in thehorizontal regridding) but it addresses the immediate issues with
MOM_read_data().