Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the main menu with Run/Stop propagates the keypress to the C64 #80

Closed
sy2002 opened this issue Jun 19, 2023 · 1 comment
Closed
Assignees
Labels
5.1 (R4/R5 Surge) bug Something isn't working

Comments

@sy2002
Copy link
Collaborator

sy2002 commented Jun 19, 2023

In V5 we introduced a new feature: You can go one menu-level up (from a sub-menu to the main-menu) by pressing Run/Stop. Subsequently you can also close then main menu via Run/Stop (additionally to via Help). But if you do so, the Run/Stop keypress that happens to close the OSM is propagated to the C64.

You can see this for example if you run

10 PRINT "HELLO"
20 GOTO 10

and then - while this BASIC program is running - you open the OSM and then close it via Run/Stop: The BASIC program will be interrupted.

Expected behavior:

The Run/Stop keypress that happens within the OSM shall not be propagated to the C64 core.

@sy2002 sy2002 added bug Something isn't working V6 or later labels Jun 19, 2023
@sy2002 sy2002 self-assigned this Oct 20, 2023
sy2002 added a commit that referenced this issue Oct 29, 2023
In V5 we introduced a new feature: You can go one menu-level up (from a sub-menu to the main-menu) by pressing Run/Stop. Subsequently you can also close then the main menu via Run/Stop (additionally to via Help). But if you do so, the Run/Stop keypress that happens to close the OSM is propagated to the C64. Fixes: #80
@sy2002
Copy link
Collaborator Author

sy2002 commented Oct 29, 2023

Fixed with commit f53356a

@sy2002 sy2002 closed this as completed Oct 29, 2023
sy2002 added a commit to sy2002/MiSTer2MEGA65 that referenced this issue Oct 29, 2023
The keypress of "Run/Stop" was propagated to the actually running core if you used Run/Stop to close the menu. This lead to undesired consequences for example on the C64: MJoergen#80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.1 (R4/R5 Surge) bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant