Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuning clean up #299

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Tuning clean up #299

merged 6 commits into from
Oct 31, 2024

Conversation

EthanMarx
Copy link
Contributor

  • Integrating with the latest lightray update which now exposes most of the tune.Tuner API. This will allow users to configure things like the TrialScheduler, SearchAlg etc.
  • Adds TuneLocal task which works the same way as TrainLocal vs TrainRemote: If AFRAME_TRAIN_RUN_DIR is an s3:// path will tune remotely.
  • Removes TraceModel callback, which was unnecessary to do at the end of every epoch for every trial, and was contributing to some bottlenecks. Don't yet have a cleaner solution for automatically tracing the best model, so will have to do it by hand for now.

Copy link
Contributor

@wbenoit26 wbenoit26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think there's just a typo in bbh.yaml and bns.yaml

wbenoit26
wbenoit26 previously approved these changes Oct 30, 2024
@EthanMarx
Copy link
Contributor Author

Looks good, I think there's just a typo in bbh.yaml and bns.yaml

What was the typo in bbh.yaml?

@wbenoit26
Copy link
Contributor

I thought it was also "progres" instead of "progress", but it looks like I misread it, or just looked at bns.yaml twice

@EthanMarx
Copy link
Contributor Author

@wbenoit26 can I get an approval when you get a chance?

@EthanMarx EthanMarx merged commit 2bb1a4c into ML4GW:main Oct 31, 2024
4 checks passed
@EthanMarx EthanMarx deleted the remove-tune-bottlenecks branch October 31, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants