-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ad action delay option #263
Add ad action delay option #263
Conversation
I am unsure about the name to use for the option, so feel free to suggest better ones. I have not fully tested it yet, which is why I marked it as a draft. |
Ad Detection
It might be call twice because the app did not have the focus yet, |
It might work for Spotify, but if another music app is used (which is my use case), we also need to change the sleep time in the other methods where there is no tabbing involved. |
After a few tests, it seems to work pretty well on my end. Would it be clearer if the option was named "Media control delay"/"Délai des contrôles de médias"? Or could this potentially be used for OBS/future plans for another ad detection plugin? |
no future plan for addons, this name fits the current state of the code, we will see if this option name still make sense if new addons are added |
Ok. I will push the updated labels/variable names tomorrow. |
this is ready for testing. once one of us approves it, this will be merged |
Enables customization of the delay before playing, pausing or skipping to next track in the ad detection feature.
Can fix an issue where Pause() is called twice in a row if the first one completes too early.
Replaces the hard coded 100ms delay with a default 100ms delay.