Merge dev into main - v0.2.0 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit staging * upgrades to dependent libraries * use of Celery to manage background tasks * replacing JSSImporter logic with JamfUploader * Some cleanup and standardization
* Completing logic in the tasks and the routes in /autopkg that call those tasks * Updating endpoints to use new celery tasks and removing BackgroundTasks usage * Converting recipe trust DB objects to their own table * Other minor updates
Tweaked task for pkg_only workflows -- may not actually need a separate recipe template for pkg only runs
Also adding verbatim to error messages
Add an "Acknowledge" button to error messages to simplify deleting error messages.
* Switched to use proper models in `trust`-related functions * Updated variable names to match proper naming convention * Bug Fix: Fixed order of passing variables in some of the `trust`-related functions
Added logic so that Child Tasks will be recorded in their Parent Task and getting the results will return a proper response
Added logic so that Child Tasks will be recorded in their Parent Task and getting the results will return a proper response (Bug Fix: Incorrect method used on list)
+ Improved redaction of sensitive strings logic + Expanded how checks are done + Added additional parsing to automatically find additional strings to redact + User can include additional keys to look for as well + Probably a bug fix or two
* (Prep for future feature) * This will allow non-PkgBot Admins to review Task results, but without including sensitive strings in the output, which more verbose (`-vvv`+) runs could include
If a prod run is pkg_only, it won't have an icon and an icon _should_ have already been identified on the dev run anyways.
+ Improved redaction of sensitive strings logic + Expanded how checks are done + Added additional parsing to automatically find additional strings to redact + User can include additional keys to look for as well + Probably a bug fix or two
This caused undesired affects and really should be applied to the entire `block` object that is sent to the Slack API. I originally did this out of an abundance of caution, but it should be more strategically done, specifically on any/the _actual content_ being posted in a message.
So `autopkg run`s will be able to capture Python tracebacks.
Finally removing these files -- only kept them to remind me to create a new method to "import" recipes into PkgBot.
Switch from using the sync `requests` library to async `httpx` library.
Forgot to do this in a previous commit.
* Removed a lot of notes, unused and old code from previous iteration of this project * Standardized numerous bits of code * Likely fixed a few minor items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the dev branch into the main branch.
This checks all the boxes that I wanted to accomplish to release this version.