Major refactor #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major refactor
* Moved core logic out of API modules
* Initialization of both the FastAPI App and Celery App improved
Improved Login Experience
* Appropriate verbose message based on the situation
* Values are required in the username and password fields before clicking submit
* Includes bug fix for new users not being able to login
ChatBot/SlackBot Changes
* Added (potential) initial support for other chat bot services
* Moved Slack Bot message creation outside of main project directories so that it can be overridden if desired
* Added support for Slack API rate-limiting in the `delete_message` method
* Plan to add support to additional methods in the future
Celery
* Using `@shared_task` decorator to call Tasks
* Overall improvements and standardization to when calling Tasks
Other minor improvements and changes:
* Set Default AutoPkgCMD Verb when using `/autopkg/` API endpoints
* Allow the timezone to be overridden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactor
Improved Login Experience
ChatBot/SlackBot Changes
delete_messagemethodCelery
@shared_taskdecorator to call TasksOther minor improvements and changes:
/autopkg/API endpoints