Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 112 Get Pipeline Inputs #117

Merged
merged 4 commits into from
Jan 14, 2020
Merged

Conversation

erica-chiu
Copy link
Contributor

Resolves #112

@claassistantio
Copy link

claassistantio commented Jan 9, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #117 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #117     +/-   ##
=========================================
+ Coverage   78.58%   78.78%   +0.2%     
=========================================
  Files           5        5             
  Lines         691      707     +16     
=========================================
+ Hits          543      557     +14     
- Misses        148      150      +2
Impacted Files Coverage Δ
mlblocks/mlpipeline.py 88.23% <100%> (+0.12%) ⬆️
mlblocks/discovery.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 949c8b1...1dd0f37. Read the comment docs.

Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution @erica-chiu !

I added some comments to reduce a little bit the code duplication, but once this is addressed the code seems ready to go in.

Also remember about adding yourself to the AUTHORS list! :-)

mlblocks/mlpipeline.py Outdated Show resolved Hide resolved
mlblocks/mlpipeline.py Outdated Show resolved Hide resolved
mlblocks/mlpipeline.py Outdated Show resolved Hide resolved
tests/test_mlpipeline.py Show resolved Hide resolved
Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good @erica-chiu !
Just one last thing before merging.

Would you mind changing the "Vertical" multi-line method calls to "Vertical Hanging Indent" or "Hanging Grid"?
You will see what I mean here: https://github.com/timothycrosley/isort#multi-line-output-modes
More specifically, using styles 3 or 4 instead of 1.

I know it is not an important change, but it is to keep a constant styling with the rest of the project.

Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erica-chiu !

@csala csala added this to the 0.3.5 milestone Jan 14, 2020
@csala csala merged commit 390606a into MLBazaar:master Jan 14, 2020
@csala csala removed this from the 0.3.5 milestone Jan 14, 2020
gsheni pushed a commit that referenced this pull request Aug 29, 2022
Issue 103: Primitive for `sklearn.linear_model.MultiTaskLasso`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Pipeline Inputs
4 participants