Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 149: VGG-like Convolutional Neural Network Classifier #152

Merged
merged 5 commits into from
Apr 20, 2019

Conversation

Hector-hedb12
Copy link
Contributor

@Hector-hedb12 Hector-hedb12 commented Apr 4, 2019

Resolves #149

Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good @Hector-hedb12 !
There is only one thing that should be removed and it can go in.

0.75
]
},
"batch_size": {
Copy link
Contributor

@csala csala Apr 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

batch_size is currently ignored by the keras adapter, so this line can be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csala
Copy link
Contributor

csala commented Apr 14, 2019

Also @Hector-hedb12, after #143, we should try to always add a verbose fixed hyperparameter defaulting to False in all keras.Sequential based primitives to allow controlling their verbosity.

@Hector-hedb12
Copy link
Contributor Author

Also @Hector-hedb12, after #143, we should try to always add a verbose fixed hyperparameter defaulting to False in all keras.Sequential based primitives to allow controlling their verbosity.

Added in 904a33c

@@ -91,6 +91,14 @@
"type": "int",
"default": 20
},
"verbose": {
"type": "int",
"default": 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the default to 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csala csala merged commit a83234c into MLBazaar:master Apr 20, 2019
@csala
Copy link
Contributor

csala commented Apr 20, 2019

Thanks @Hector-hedb12 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VGG-like convnet primitive
2 participants