Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented command to download the Hermes Sampling Profiler to a local machine #2

Merged
merged 7 commits into from
Jul 27, 2020

Conversation

jessieAnhNguyen
Copy link
Member

@jessieAnhNguyen jessieAnhNguyen commented Jul 21, 2020

Summary

  • Solves Add a command to download Hermes profile #1

  • Add packages/cli/src/commands/profile: a folder for Hermes Sampling Profile related commands

  • File packages/cli/src/commands/profile/index.ts: exporting the default command profile-hermes [destinationDir] --fileName [string]

  • File packages/cli/src/commands/profile/downloadProfile.ts: implement the functions that help with the above command 👆

  • Command added in the file packages/cli/src/commands/index.ts: add the profile command in the list of projectCommands

Test Plan:

  • I first followed this guide on how to test changes Testing changes.

  • After that, the usage of the command is:

    • Navigate to the directory of a React Native project
    • Run the command profile-hermes [destinationDir] --fileName [string] with appropriate inputs
      • destinationDir: is optional, provided it with the directory where users want to pull the profile to (if not present, pull to the current React Native root directory)
      • --fileName [string] an option to specify which profile users want to pull (if not present, pull the latest profile)
  • Make sure your emulator is running and adb is connected

@jessieAnhNguyen jessieAnhNguyen marked this pull request as ready for review July 22, 2020 07:47
@jessieAnhNguyen jessieAnhNguyen linked an issue Jul 22, 2020 that may be closed by this pull request
2 tasks
.vscode/settings.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@jevakallio jevakallio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: 😍

@jessieAnhNguyen jessieAnhNguyen self-assigned this Jul 23, 2020
Copy link
Member

@saphal1998 saphal1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jessieAnhNguyen jessieAnhNguyen merged commit defc7b7 into master Jul 27, 2020
@jessieAnhNguyen jessieAnhNguyen deleted the jessie branch July 27, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a command to download Hermes profile
3 participants