-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Part 1] Individual Test Case Report - Support custom messages #5
Conversation
@jevakallio @kunal-kushwaha Could you try running A single test case is always failing (in the CI build too). Any reasons why? Test Result: ❯ yarn jest
yarn run v1.22.4
$ node ./packages/jest-cli/bin/jest.js
FAIL e2e/__tests__/customTestSequencers.test.ts (5.815 s)
● run prioritySequence first async
expect(received).toBe(expected) // Object.is equality
Expected: 0
Received: 1
48 | {},
49 | );
> 50 | expect(result.exitCode).toBe(0);
| ^
51 | const sequence = extractSummary(result.stderr)
52 | .rest.replace(/PASS /g, '')
53 | .split('\n');
at Object.toBe (e2e/__tests__/customTestSequencers.test.ts:50:27)
|
@sauravhiremath: I'm also facing the same error 😕 |
Ahh @kunal-kushwaha no worries. I just resolved the issue, had to add async for running test sort. I didn't know Push coming in a bit :) |
@jevakallio it works!! Could you have a look if any changes required? |
@sauravhiremath nice! 🎉 I ran out of time today, will review this tomorrow morning! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sauravhiremath I didn't review @rogeliog
's commits because I have no context for them. I did review the cleanup commits you had made on top, and had some questions and notes on them.
Some comments I made were already changed in following commits you had made, so apologies if anything is redundant.
Overall, I'm seeing a lot of code style changes, but I don't understand why those changes were made? If they are to conform to Jest code standards or linter rules, that's good. But if not, the general advice I would have is not to change code for purely aesthetic reasons, unless there's a rationale for it.
0c358c3
to
432bbce
Compare
… with coverage, by caching micromatch and avoiding recreating RegExp instances (jestjs#10131) Co-authored-by: Christoph Nakazawa <cpojer@fb.com>
(Typo) Removed word "to"
cd9918d
to
feb63cf
Compare
@kunal-kushwaha , you can make this PR to facebook upstream if you want! |
@sauravhiremath This looks great! Made one 🎉 |
f8fbd6b
to
45492fa
Compare
Merged into |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
PART 1 of 2
Aim: Support custom messages for jest worker
Fixes: #1
Ref: jestjs#9662
Note
Test plan
An extension from jestjs#9662