Skip to content

Commit

Permalink
Fix lint rules in version 0.28 (facebook#1410)
Browse files Browse the repository at this point in the history
* Initial commit

* Issue facebook#1338 V0.28 Corrects insensitive or inconsiderate language in version-28 of React Native Docs

* Resolving merge conflict in alexignore file

* facebook#1338 Removes version-28 from alexignore

* Delete yarn.lock
  • Loading branch information
emilyannemoses authored and rickhanlonii committed Oct 19, 2019
1 parent 64851ac commit 21229fa
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
3 changes: 1 addition & 2 deletions .alexignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ website/blog/
website/versioned_docs/version-0.16/
website/versioned_docs/version-0.18/
website/versioned_docs/version-0.22/
website/versioned_docs/version-0.28/
website/versioned_docs/version-0.29/
website/versioned_docs/version-0.43/
website/versioned_docs/version-0.46/
website/versioned_docs/version-0.53/
website/versioned_docs/version-0.53/
2 changes: 1 addition & 1 deletion website/versioned_docs/version-0.28/appstate.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Add a handler to AppState changes by listening to the `change` event type and pr
| type | string | Yes | |
| handler | function | Yes | |

TODO: now that AppState is a subclass of NativeEventEmitter, we could deprecate `addEventListener` and `removeEventListener` and just use `addListener` and `listener.remove()` directly. That will be a breaking change though, as both the method and event names are different (addListener events are currently required to be globally unique).
TODO: now that AppState is a subclass of NativeEventEmitter, we could deprecate `addEventListener` and `removeEventListener` and use `addListener` and `listener.remove()` directly. That will be a breaking change though, as both the method and event names are different (addListener events are currently required to be globally unique).

---

Expand Down
4 changes: 2 additions & 2 deletions website/versioned_docs/version-0.28/asyncstorage.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ title: AsyncStorage
original_id: asyncstorage
---

AsyncStorage is a simple, asynchronous, persistent, key-value storage system that is global to the app. It should be used instead of LocalStorage.
AsyncStorage is an asynchronous, persistent, key-value storage system that is global to the app. It should be used instead of LocalStorage.

It is recommended that you use an abstraction on top of AsyncStorage instead of AsyncStorage directly for anything more than light usage since it operates globally.

On iOS, AsyncStorage is backed by native code that stores small values in a serialized dictionary and larger values in separate files. On Android, AsyncStorage will use either RocksDB or SQLite based on what is available. This JS code is a simple facade that provides a clear JS API, real Error objects, and simple non-multi functions. Each method returns a `Promise` object.
On iOS, AsyncStorage is backed by native code that stores small values in a serialized dictionary and larger values in separate files. On Android, AsyncStorage will use either RocksDB or SQLite based on what is available. This JS code is a facade that provides a clear JS API, real Error objects, and non-multi functions. Each method returns a `Promise` object.

### Methods

Expand Down
6 changes: 3 additions & 3 deletions website/versioned_docs/version-0.28/scrollview.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ original_id: scrollview

Component that wraps platform ScrollView while providing integration with touch locking "responder" system.

Keep in mind that ScrollViews must have a bounded height in order to work, since they contain unbounded-height children into a bounded container (via a scroll interaction). In order to bound the height of a ScrollView, either set the height of the view directly (discouraged) or make sure all parent views have bounded height. Forgetting to transfer `{flex: 1}` down the view stack can lead to errors here, which the element inspector makes easy to debug.
Keep in mind that ScrollViews must have a bounded height in order to work, since they contain unbounded-height children into a bounded container (via a scroll interaction). In order to bound the height of a ScrollView, either set the height of the view directly (discouraged) or make sure all parent views have bounded height. Forgetting to transfer `{flex: 1}` down the view stack can lead to errors here, which the element inspector can be utilized to debug.

Doesn't yet support other contained responders from blocking this scroll view from becoming the responder.

Expand Down Expand Up @@ -391,8 +391,8 @@ When true, the ScrollView will try to lock to only vertical or horizontal scroll
The style of the scroll indicators.

- `default` (the default), same as `black`.
- `black`, scroll indicator is black. This style is good against a white content background.
- `white`, scroll indicator is white. This style is good against a black content background.
- `black`, scroll indicator is dark in color. This style is good against a light content background.
- `white`, scroll indicator is light in color. This style is good against a dark content background.

| Type | Required | Platform |
| --------------------------------- | -------- | -------- |
Expand Down

0 comments on commit 21229fa

Please sign in to comment.