Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from facebook:master #265

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Commits on Oct 8, 2020

  1. Remove 'qs' dependency, update yarn lock (#30125)

    Summary:
    This PR removes unused `qs` package (query string parser) from the main `package.json` file.
    
    I was not able to find any explicit usage of this package in the repository. Looking at the commit which introduced this package it is not clear why it has been added, query string is not processed in any way.
    
    I have also run ` yarn update-lock` to clean up lock after latest dependencies bumps. There are no `qs` package entry removal in yarn lock, because it is already required by `request` package.
    
    Refs: b4785e5
    
    ## Changelog
    
    <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
    https://github.com/facebook/react-native/wiki/Changelog
    -->
    
    [Internal] [Removed] - remove unused `qs` dependency
    
    Pull Request resolved: #30125
    
    Test Plan: This change should not affect the code base.
    
    Reviewed By: appden
    
    Differential Revision: D24184372
    
    Pulled By: cpojer
    
    fbshipit-source-id: 4f159f3c554c48ed21839370c8370848df181046
    Simek authored and facebook-github-bot committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    38bc5df View commit details
    Browse the repository at this point in the history