Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] master from facebook:master #324

Merged
merged 2 commits into from
Oct 24, 2020
Merged

[pull] master from facebook:master #324

merged 2 commits into from
Oct 24, 2020

Commits on Oct 24, 2020

  1. Bump Node LTS to 14, and Node PrevLTS to 12. (#30237) 

    Summary:
On October 27, 2020, Node 14 will enter active LTS status, and Node 12 will enter maintenance LTS status at the end of November.

With these upcoming dates in mind, I am bumping the Circle CI NodeLTS executor to use Node 14, and the NodePrevLTS executor to use Node 12.

With these changes, Node 12 will be hereto considered the minimum supported version.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[Changed] [JavaScript] - Bump minimum Node version to 12 LTS

Pull Request resolved: #30237

Test Plan: Circle CI

Reviewed By: PeteTheHeat

Differential Revision: D24513133

Pulled By: hramos

fbshipit-source-id: 2651d954d546e5f7c9e40b54ef3ee976ad9b2d5e
    @hramos @facebook-github-bot
    hramos authored and facebook-github-bot committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    0d1f93c View commit details
    Browse the repository at this point in the history

  2. Synchronize RCTImageLoader loaders initialization 

    Summary:
The method `imageURLLoaderForURL` can be called from multiple threads. This adds a mutex to make sure that _loaders is initialized with a non-nil value only once.

We'll only lock this mutex at one point in time as long as `_loadersProvider()` gives a value, so the mutex doesn't affect performance.

Changelog: [iOS][Fixed] Synchronize RCTImageLoader loaders initialization

Reviewed By: fkgozali

Differential Revision: D24513083

fbshipit-source-id: b89ef8a82729eda508162b01f7fdaa8a291f40d0
    @p-sun @facebook-github-bot
    p-sun authored and facebook-github-bot committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    edb6fa7 View commit details
    Browse the repository at this point in the history