-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the FlatList Component in Lists #41
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment to improve the faded edge docs, but otherwise LGTM!
@ayushjainrksh these component props are defined on the underlying VirtualizedList. The documentation for FlatList states "This is a convenience wrapper around , and thus inherits its props (as well as those of ) that aren't explicitly listed here". I would read this to mean that these props should not be documented here. From the point of view of the documentation reader it might be useful to have better indication in the docs what props are being inherited from other components, so that the developer knows they can be passed to this component. I think best way forward is to remove these for now, and create a new issue for improving inherited prop visibility overall. Thoughts @motiz88? |
1eb1baf
to
09cc2d8
Compare
cacbc0e
to
d4a2836
Compare
* Update the title, prop descriptions and method descriptions from docs. * Add SnackPlayer examples. * Remove unnecessary asterisks in comments. * Wrap comments to 80 characters * Add description to method FlowTypes * Add prop types with type annotation
d4a2836
to
f5577ba
Compare
Fixes #32
Summary