[pull] master from facebook:master #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Summary: Changelog: These are no longer being used by Buck, we can just remove them. Reviewed By: zigwei Differential Revision: D26913017 fbshipit-source-id: c75a07b2dc8c337ceef6da275b0046c0ac048ba7
Summary: Changelog: [internal] "onDismiss" event wasn't called in Fabric. This diff adds it. Paper implementation of Modal uses `RCTEventEmitter` instead of callback to deliver the event. To align better with Paper, Fabric will follow this pattern. Reviewed By: shergin Differential Revision: D26911312 fbshipit-source-id: b0de619c5a02c3378d1f7ac3ce1b705bb5fb634d
Summary: Changelog: [Internal] Flipper moved to maven central recently, so we can remove exceptions for it. Reviewed By: fkgozali Differential Revision: D26915353 fbshipit-source-id: c245e25ecb0eef1e279f197c2717673ec9ce3ca1
Summary: Fix warnings about implicit type truncation. ## Changelog [Internal] [Fixed] - Fix various C++ warnings Pull Request resolved: #31002 Test Plan: Almost all the changes here are simply making explicit conversions which are already occurring. With the exception of a couple of constants being changed from doubles to floats. With these changes I am able to remove a bunch of warning suppressions in react-native-windows. Reviewed By: shergin Differential Revision: D26900502 Pulled By: rozele fbshipit-source-id: d5e415282815c2212a840a863713287bbf118c10
…1068) Summary: Pull Request resolved: facebook/yoga#1068 There is an issue in react-native when the Yoga node position type is set to absolute and display: none is set where the node layout calculation gives the absolute dimensions, rather than the expected 0 x 0. Here are some OSS issues tracking this: #18415 microsoft/react-native-windows#7289 ## Changelog [General] [Fix] - Fixes layout of nodes with YGDisplayNone and YGPositionTypeAbsolute Reviewed By: Andrey-Mishanin Differential Revision: D26849307 fbshipit-source-id: 197618aa3c4e1b3b7efeba7ea4efd30b2d1c982d
Summary: This NativeModule will now be type-safe, and TurboModule-compatible. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D26956332 fbshipit-source-id: 6651a003c70819934869dd6a8c664ef984d0efcb
…liminated
Summary:
mHybridData should have a SuppressWarnings("unsed") annotation on it. Furthermore, we should add a DoNotStrip annotation, to make sure that the HybridData object doesn't get removed. We do the same in TurboModuleManager:
https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/xplat/js/react-native-github/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java?commit=5e1cd0c2ed84ff8e718473ff26145733868ebaba&lines=46-48
Changelog: [Internal]
Created from Diffusion's 'Open in Editor' feature.
Reviewed By: fkgozali
Differential Revision: D26958686
fbshipit-source-id: 83c0626c0681966dfcda7f6e4fb4cbeac8340b3f
Summary: The documentation of jsi::Value::strictEquals was confusing it with SameValue (which differs in treatment of signed zeroes and NaN). Fix it by referring to the correct part of the spec. Changelog: [Internal][Fixed] - Fix incorrect comment Reviewed By: avp Differential Revision: D26430216 fbshipit-source-id: 0ea4208fbdda40c87f8028231ddefb2323b6eb96
Summary: Changes `Dimensions.addEventListener` to return an `EventSubscription` object that has a `remove()` method on it. In an upcoming commit, calling `Dimensions.removeEventListener` will lead to a deprecation warning. Changelog: [General][Change] - `Dimensions.addEventListener` now returns an `EventSubscription`. Reviewed By: kacieb Differential Revision: D26808827 fbshipit-source-id: 0cfdc65b83c177f60937c1aa3a4cf633592f73d7
Summary: Restore deprecated event listener removal methods in order to minimize breaking changes for the next release. The methods will work, but they will not report a warning via `console.error`. Changelog: [General][Added] - `EventEmitter.removeListener` now emits a deprecation notice. [General][Added] - Restored `AppState.removeEventListener` with a deprecation notice. [General][Added] - Restored `Keyboard.removeEventListener` with a deprecation notice. [General][Added] - Restored `Linking.removeEventListener` with a deprecation notice. Reviewed By: nadiia, kacieb Differential Revision: D26589441 fbshipit-source-id: 7d89982a182cf2163136e157d4c1beee91c30393
Summary: See react-native-community/discussions-and-proposals#335 for extra context. A VirtualizedList may have sticky headers, forwarded on to ScrollView. These sticky headers are exempt from virtualization once realized for the first time. This change documents the behavior of keeping sticky header cells realized after scrolling away. This scenario performs the same behavior as creating an internal "realization window" for sticky headers with a single cell window size. Generalizing the concept of realization windows should be shaped to support the existing sticky header scenario. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal] [Added] - Add tests describing current sticky header realization behavior Pull Request resolved: #31075 Reviewed By: lunaleaps Differential Revision: D26767582 Pulled By: appden fbshipit-source-id: 0d151bd6046fcb5384c646205aafa1ca7edf6c77
Summary: Does not impact prod or even debug builds unless you switch on the debug flag. The issue is that we were trying to coerce booleans to integers. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D26970274 fbshipit-source-id: 3327029ae3afc307dd19b089c23c190cb9e3150c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )