[pull] master from facebook:master #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Summary: This diff contains the code from the 35 diff stack - D27210587 This diff implement and integrates Mapbuffer into Fabric text measure system changelog: [internal] internal Reviewed By: JoshuaGross Differential Revision: D27241836 fbshipit-source-id: f40a780df0723f27da440f709a8676cfcca63953
Summary: This is a core part of the Timeline feature (aka Time Travel Debugger). With these new primitives, any external library can initiate "saving" all the previous interface changes (commits) and unwind to any previous one (in order to introspect and validate visual side-effects). The next diff in the stack will implement UI for this feature integrated into Debug menu on iOS. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D25926660 fbshipit-source-id: 2e5f6892351d3053db8f64c1cf6ff445b0867ad7
Summary: Changelog: [Internal] FabricUIManager contains a lot of logic related to mounting items and manipulating dispatch queues, which can be safely extracted outside. Apart from decreased logical complexity, this change enables easier modification of the queuing behavior later in this stack. Majority of the changes is caused by moving existing logic to a different class, no change in behavior expected. Reviewed By: JoshuaGross Differential Revision: D27271116 fbshipit-source-id: 86fe45b19bb839f96fde8ba607f72006f6401cc7
Summary: This diff changes the syntax of class variables in MapBuffer class to make it consistent with standards changelog: [internal] internal Reviewed By: JoshuaGross, sammy-SC Differential Revision: D27303497 fbshipit-source-id: 7581ce248559726c301ae96312fcb597a061ad5f
Summary: This diff changes the syntax of class variables in MapBufferBuilder class to make it consistent with standards changelog: [internal] internal Reviewed By: JoshuaGross Differential Revision: D27303495 fbshipit-source-id: b62067a07c5b2df1ae79b0134343d30ec819a55f
Summary: In Fabric we don't throw exception. This diff removes exception from MapBuffer class changelog: [internal] internal Reviewed By: JoshuaGross, sammy-SC Differential Revision: D27303496 fbshipit-source-id: 3f8c3bd2b41121672ef05153459b20cdc2efcda3
Summary: In Fabric we don't throw exception. This diff removes exception from MapBufferBuilder class changelog: [internal] internal Reviewed By: JoshuaGross, sammy-SC Differential Revision: D27303493 fbshipit-source-id: 8303bb4be786e2ea175b6741ec536c0f54615001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )