[pull] master from facebook:master #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Summary: changelog: [internal] Fabric is missing implementation of PlatformColor APIs. If it is used, it causes a crash. Until it is implemented, let's remove abort statement and continue with transparent color. Reviewed By: mdvacca Differential Revision: D27395917 fbshipit-source-id: 50d541c5cacc10a7652f7f1ddc97e086a4ba8f03
…hange Summary: Changelog: [Internal][Added] - Use injected ScrollViewStickyHeader if set Reviewed By: lunaleaps Differential Revision: D26931404 fbshipit-source-id: 6f6f1b501b610a05999898be3e2ce08aeb4dab1b
Summary: Changelog: [Internal] - Simplify logic by not creating an unnecessary object Reviewed By: kacieb Differential Revision: D27371155 fbshipit-source-id: c34db151f57f9f6e46cc1984a5a9ef24f81adecd
Summary: Changelog: [Internal] - Add more testIDs to SwitchExample Reviewed By: kacieb Differential Revision: D27371058 fbshipit-source-id: d2d90923c2c07cd86fd9aa965339dadf43f8fb5f
Summary: Log more diagnostics about this assertion failure. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D27407775 fbshipit-source-id: 7f00215b8b2c0ad7378c5671f3b503daf56b9fd2
Summary: Just makes it easier to log and inspect these values. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D27407778 fbshipit-source-id: 68e93d100b56bc9065f0ff1370260412d729312d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )