Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make caching optional #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bensialih
Copy link

@bensialih bensialih commented Dec 29, 2024

Fixes #12
added caching variable to make caching optional. Unit tests added to test this.

Motivation
When adding facts dynamically, I would like to make the same query multiple times.
Making the same query multiple times will only returned the cache results instead of the updated results.

Solution
Add marker to allow caching to be optional to the query function.

Unit tests
create new KnowledgeBase and add new entries to highlight the problem.
create new KnowledgeBase and add new entries and make the same queries with the cache marker set to False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional caching
1 participant