Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(release): fix distribution example script check #1841

Merged
merged 2 commits into from
May 22, 2024

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented May 22, 2024

Remove break statement likely leftover from development/debugging, which caused only the first example model to get a test run. This is why the examples script issue addressed by MODFLOW-USGS/modflow-devtools#156, where models were written to runall.[sh/bat] in an order which did not respect flow model dependencies, was not caught before.

After this PR, the runall.[sh/bat] script will be tested, as well as 3 of the separate example scripts picked at random.

wpbonelli added 2 commits May 22, 2024 12:51
* remove break statement likely leftover from development/debugging
* only the first example model was getting tested, now they all will
@wpbonelli wpbonelli marked this pull request as ready for review May 22, 2024 19:19
@wpbonelli wpbonelli merged commit d36faa6 into MODFLOW-USGS:develop May 22, 2024
6 checks passed
@wpbonelli wpbonelli deleted the check-dist branch May 22, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant