remove DOMParser(), decode compatible with Web Workers #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for your PR! Looks good to me but there's an eslint check failed, can you have a look ( |
features like Offscreen Canvas use Web Workers. If we want to process a gainmap embedded in a JPEG, we won't have access to DOMParser() and thus need a compatible alternative. This is a simple Regex approach to get around it.
|
Alright, there were trailing spaces in two lines 🥴 now it should be good |
|
aww, shit, the commit message format didn't trigger an automatic release, I'm going to trigger one "artificially", thanks for this in the meanwhile! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features like Offscreen Canvas use Web Workers. If we want to process a gainmap embedded in a JPEG, we won't have access to DOMParser() and thus need a compatible alternative. This is a simple Regex approach to get around it.
All test pass correctly :)