Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #228 - 클라이언트 에러 대응 #229

Merged
merged 5 commits into from
Feb 28, 2024
Merged

[Fix] #228 - 클라이언트 에러 대응 #229

merged 5 commits into from
Feb 28, 2024

Conversation

its-sky
Copy link
Member

@its-sky its-sky commented Feb 28, 2024

🚀PullRequest🚀

📟 관련 이슈

💻 작업 내용

  • SecurityConfig에 테스트 클라이언트 URL CORS 정책 허용 하였습니다.
  • Initial O-KR 생성 시 undefined(null)에 대한 처리가 되어 있지 않아 KeyResultService에 들어오는 dto를 not null filtering 처리를 하였습니다.
  • moonshot-auth 모듈에 일부 코드 패키징 설정이 잘못되어 있어 재설정하였습니다.

📝 리뷰 노트

image

@its-sky its-sky requested a review from 0lynny February 28, 2024 15:59
@its-sky its-sky self-assigned this Feb 28, 2024
0lynny
0lynny approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@0lynny 0lynny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에러대응하느라 수고 많으셨습니다~! 감사합니다 !

@its-sky its-sky merged commit 3c54146 into develop Feb 28, 2024
1 check passed
@its-sky its-sky deleted the feature/#228 branch March 12, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0lynny 0lynny 0lynny approved these changes

Assignees

@its-sky its-sky

Labels
민철👃🏼 🚀SP1 Sprint 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 클라이언트 에러 대응
2 participants
@its-sky @0lynny