[Feat] #282 - 소셜 API 구현 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its-sky
approved these changes
May 31, 2024
| .join(objective.keyResultList, keyResult).fetchJoin() | ||
| .join(keyResult.taskList, task) | ||
| .where(objective.isPublic.eq(true)) | ||
| .orderBy(objective.heartCount.desc(), objective.id.desc()) |
There was a problem hiding this comment.
p4;
이러면 만약 특정 Objective가 인기가 좋아서 하트를 많이 받았다는 상황을 가정해보겠습니다.
그러면 하트를 많이 받았던 Objective는 지속적으로 상단에 노출되는 문제가 있는데요.
이부분에 대해서는 어떻게 생각하실까요?
지금은 임시적이지만 답변 부탁드립니다 :)
저는 개인적으로 heartCount가 중요 factor라는 것에는 동의하지만 aging을 통해 우선순위를 낮춰줄 필요도 있다고 생각합니다 !
There was a problem hiding this comment.
그렇네요 ... 그 부분까지는 고려못했던 것 같습니다.. 일단 최신순 정렬로 다시 수정해두겠습니다 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀PullRequest🚀
📟 관련 이슈
💻 작업 내용
📝 리뷰 노트