Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #58 - KeyResult 엔티티 변경에 따른 LogService, KeyResultService 변경 #59

Merged
merged 6 commits into from
Jan 10, 2024

Conversation

0lynny
Copy link
Member

@0lynny 0lynny commented Jan 10, 2024

🚀PullRequest🚀

📟 관련 이슈

💻 작업 내용

  • 엔티티 변경에 따른 keyResultService, LogService 수정했습니다.

  • 기존 progress 계산을 keyResultService에서 진행하였는데 logService로 이동하였습니다.

  • 기획 측 요구에 따라 이전값보다 큰 값을 입력 받았던 진척상황을 같은 상황일때만 예외가 발생하도록 수정하였습니다. (KR 수정 Log도 동일)

스크린샷 2024-01-11 오전 6 03 22
  • Recordlog, UpdateLog가 생성되면 keyResult progress값 변경되도록 구현하였습니다.

📝 리뷰 노트

없습니다!

Copy link
Member

@its-sky its-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 했 다 최 영 린 짝 짝 박 수 ! !

@0lynny 0lynny self-assigned this Jan 10, 2024
@0lynny 0lynny changed the title Feature/#58 [Fix] KeyResult 엔티티 변경에 따른 LogService, KeyResultService 변경 Jan 10, 2024
@0lynny 0lynny merged commit f54afe1 into develop Jan 10, 2024
1 check passed
@0lynny 0lynny changed the title [Fix] KeyResult 엔티티 변경에 따른 LogService, KeyResultService 변경 [Fix] #58 - KeyResult 엔티티 변경에 따른 LogService, KeyResultService 변경 Jan 10, 2024
@0lynny 0lynny deleted the feature/#58 branch January 10, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] KeyResult 엔티티 변경에 따른 LogService, KeyResultService 변경
2 participants