#418: Fix event end time in CalendarService #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the event end time to set the datetime to 23:59 on the planned end date, ensuring that the full day is accounted for. The change also switches the boolean to 'true' for dateEnd to reflect this update, potentially impacting how end times are processed in the calendar. This adjustment should improve the accuracy of calendar entries for studies.
Test Results18 tests 18 ✅ 2s ⏱️ Results for commit 8e6aeb2. |
ja-fra
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the event end time to set the datetime to 23:59 on the planned end date, ensuring that the full day is accounted for. The change also switches the boolean to 'true' for dateEnd to reflect this update, potentially impacting how end times are processed in the calendar. This adjustment should improve the accuracy of calendar entries for studies.