DP-1709 - Publish package to all ppas #343
Open
+179
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariana-dias-alves
requested review from
duartecoelhomovai,
diasdm,
AlexFernandes-MOVAI,
brunomovai,
RaulMovai,
DenisBorzenkov and
violetamovai
| env: | ||
| GITHUB_TOKEN: ${{ secrets.gh_token }} | ||
|
|
||
| - uses: DenverCoder1/doxygen-github-pages-action@v1 |
There was a problem hiding this comment.
| with: | ||
| python-version: '3.10' | ||
| - uses: pre-commit/action@v2.0.3 | ||
|
|
||
| Pack: | ||
| runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
why Pack does not depend on Pre-commit ?
Suggested change
| runs-on: ubuntu-20.04 | |
| runs-on: ubuntu-20.04 | |
| needs: [Pre-commit] |
| runs-on: ubuntu-20.04 | ||
| strategy: | ||
| matrix: | ||
| nexus_ppa: ["ppa-testing", "ppa-testing-focal", "ppa-testing-jammy", "ppa-testing-noble"] |
There was a problem hiding this comment.
better not to hardcode the repositories. other workflows use inputs:
testing_publish_repos:
required: false
type: string
default: ["ppa-testing", "ppa-testing-focal", "ppa-testing-jammy", "ppa-testing-noble"]
| runs-on: ubuntu-20.04 | ||
| strategy: | ||
| matrix: | ||
| nexus_ppa: [ "ppa-main", "ppa-stable-focal", "ppa-stable-jammy", "ppa-stable-noble"] |
There was a problem hiding this comment.
same here: better not to hardcode the repositories. other workflows use inputs:
prod_publish_repos:
required: false
type: string
default: [ "ppa-main", "ppa-stable-focal", "ppa-stable-jammy", "ppa-stable-noble"]
| @@ -14,6 +14,14 @@ on: | |||
| required: false | |||
| type: string | |||
| default: "v2.0.10" | |||
| ref_name: | |||
There was a problem hiding this comment.
what is this ref_name input ? please document
| if: ${{ inputs.release == 'false' && inputs.deploy == 'true' }} | ||
| runs-on: ubuntu-20.04 | ||
| strategy: | ||
| matrix: |
There was a problem hiding this comment.
avoid naming objects by their undelaying solution, prefer: artifact_repo_ppas instead of nexus_ppa
| git config --global --add safe.directory $(pwd) | ||
| mkdir artifacts | ||
| cd artifacts | ||
| gh release download ${{ inputs.ref_name }} -p *.deb |
There was a problem hiding this comment.
Suggested change
| gh release download ${{ inputs.ref_name }} -p *.deb | |
| gh release download ${{ inputs.ref_name }} -p *.deb -d artifacts |
no need to cd ;)
AlexFernandes-MOVAI
requested changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in: