Fixes temperature interpolation in landice tool conversion_exodus_init_to_mpasli_mesh.py #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ript Fix several bugs in the temperature interpolation: 1) define albanyTemperaure array size using nCells instead of np.max(cellID_array), which was causing an error in some cases; 2) remove if-statement that separates temperature from velocities based on number of vertical levels/interfaces (no longer needed with current interpolation scheme, and was not working anyway); 3) stagger albany and mpas temperature layers for interpolation by subtracting 0.5 from MPAS_layers.
trhille
force-pushed
the
landice/fix_conversion_script_temp_interp
branch
from
0103103
to
b4ceef6
Compare
Equally-spaced temperature layers works in general because MPAS temperature layers are always halfway between Albany temp layers, and we use linear interpolation. Add a comment to explain that to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several bugs that were leading to errors in some cases and incorrect 3D temperature interpolation in all cases.