Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new utility to create ESMF and SCRIP files for MPAS-A #422

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

MiCurry
Copy link
Contributor

@MiCurry MiCurry commented May 7, 2021

This merge adds a Fortran utility that can generate ESMF and SCRIP files from an MPAS mesh. Although there already exists a utility that can create SCRIP files from an MPAS mesh, that utility uses Conda, which is not part of the MPAS-Atmosphere's current workflow.

Currently, this tool is used to generating SCRIP files for MPAS in CESM.

@MiCurry
Copy link
Contributor Author

MiCurry commented May 7, 2021

@xylar Althought I don't think there is, let us know if you think there will be a conflict with this tool and the create_SCRIP_files utility.

@MiCurry MiCurry requested a review from mgduda May 7, 2021 20:54
@xylar
Copy link
Collaborator

xylar commented May 9, 2021

@MiCurry, no, there is no relation between the two tools so there should also be no interference. Thanks for asking!

@mgduda
Copy link
Collaborator

mgduda commented May 10, 2021

@MiCurry Thanks for putting together a Makefile and PR for this. I have just a few minor suggestions:

  1. Should we add a .gitignore file with mpas2esmf as its only line?
  2. Should the Makefile set FC, e.g., based on the output of $(shell nc-config --fc) as we do for grid_rotate, or is the expectation that the user will set FC on the command-line?

@MiCurry
Copy link
Contributor Author

MiCurry commented May 17, 2021

@MiCurry Thanks for putting together a Makefile and PR for this. I have just a few minor suggestions:

1. Should we add a `.gitignore` file with `mpas2esmf` as its only line?

2. Should the `Makefile` set `FC`, e.g., based on the output of `$(shell nc-config --fc)` as we do for [grid_rotate](https://github.com/MPAS-Dev/MPAS-Tools/blob/master/mesh_tools/grid_rotate/Makefile), or is the expectation that the user will set `FC` on the command-line?

Those both sounds like good ideas! I wasn't aware of nc-config --fc. I'll add them both. Do you think its worthwhile to also have the same FFLAGS used as grid_rotate?

@mgduda
Copy link
Collaborator

mgduda commented May 17, 2021

If we can avoid having to add FFLAGS, I think that's preferable, as it makes the default Makefile compatible with multiple Fortran compilers. With the grid_rotate tool, the FFLAGS only work with the GNU compiler, and users need to manually change these when switching to other Fortran compilers.

This commit adds a new Fortran utility that can be used for creating SCRIP and
ESMF files from MPAS grids. Currently, this tool is used to generate SCRIP
files for MPAS-Atmosphere in CESM.
@MiCurry
Copy link
Contributor Author

MiCurry commented May 18, 2021

@mgduda sounds good! I just pushed (force pushed) an update to this branch with the changes you requested. I also added a short README. Let me know if there is anything else.

@mgduda mgduda merged commit c2a9719 into MPAS-Dev:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants