Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fix to python mask creation #456

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Small fix to python mask creation #456

merged 1 commit into from
Apr 1, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Apr 1, 2022

This fix avoids a deprecation warning from Shapely but explicitly getting the list of geometries in a MultiPolygon object with the .geoms property.

@xylar xylar self-assigned this Apr 1, 2022
@xylar
Small fix to python mask creation
47762ab 
This fix avoids a deprecation warning from Shapely but explicitly
getting the list of geometries in a MultiPolygon object with the
`.geoms` property.
@xylar
Copy link
Collaborator Author

xylar commented Apr 1, 2022

Testing

I have run the QU240 mesh in compass through the files_for_e3sm test case, which uses the python masking. With an mpas_tools package built from this branch, I no longer see the deprecation warnings that I was seeing in previous runs.

@xylar xylar merged commit 397e117 into MPAS-Dev:master Apr 1, 2022
@xylar xylar deleted the fix_shapely_deprecated branch April 1, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
conda package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar