Add an iceMask field to the interpolation script #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an iceMask field to the interpolation script, which can be used for trimming down fields to the original extent of ice after interpolating. This is useful when fields must be extrapolated before using the interpolation script in order to avoid including zeros, NaNs, or large missing values in the interpolation at the ice edge.
| @@ -649,6 +649,7 @@ def vertical_interp_MPAS_grid(mpas_grid_input_layers, destVertCoord, input_layer | |||
| if filetype=='cism': | |||
|
|
|||
| fieldInfo['thickness'] = {'InputName':'thk', 'scalefactor':1.0, 'offset':0.0, 'gridType':'x1', 'vertDim':False} | |||
| fieldInfo['iceMask'] = {'InputName':'iceMask', 'scalefactor':1.0, 'offset':0.0, 'gridType':'x1', 'vertDim':False} | |||
There was a problem hiding this comment.
Did you mean to keep this outside of the thicknessOnly check?
There was a problem hiding this comment.
Yes, but I don't have a strong preference for where it should go.
There was a problem hiding this comment.
Although thinking about it more, I think it is placed appropriately here. The value of iceMask will give some indication of how bad the interpolation ramp is in the thickness field, while you can't know that from looking at the interpolated thickness field alone.
There was a problem hiding this comment.
Ok, that makes sense, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an iceMask field to the interpolation script, which can be used
for trimming down fields to the original extent of ice after
interpolating. This is useful when fields must be extrapolated before
using the interpolation script in order to avoid including zeros, NaNs,
or large missing values in the interpolation at the ice edge.