Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ocean topography smoothing tool #538

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Add ocean topography smoothing tool #538

merged 2 commits into from
Nov 21, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Nov 17, 2023

This tool will be used in Compass to smooth topography for EC and Icos30 meshes (perhaps others in the future).

@xylar xylar requested a review from maltrud November 17, 2023 21:17
@xylar xylar self-assigned this Nov 17, 2023
@xylar
Copy link
Collaborator Author

xylar commented Nov 17, 2023

@maltrud, I'm able to build the tool! On to Compass.

@xylar xylar force-pushed the add-smooth-topo-tool branch 3 times, most recently from 2c09ab8 to be3b239 Compare November 19, 2023 02:51
This was referenced Nov 19, 2023
Closed
Closed
@xylar xylar marked this pull request as ready for review November 20, 2023 00:45
@xylar
Copy link
Collaborator Author

xylar commented Nov 20, 2023

Testing

I used this to produce smoothed bathymetry and ice-shelf topography for the ECwISC and IcoswISC meshes in MPAS-Dev/compass#733 and MPAS-Dev/compass#734.

bottom_depth
ice_draft

maltrud
maltrud approved these changes Nov 21, 2023
View reviewed changes
Copy link

@maltrud maltrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. the guts of the algorithm that I used in my stand-alone code are replicated here, with extensions to handle ice shelf cavities.

@xylar
Copy link
Collaborator Author

xylar commented Nov 21, 2023

Excellent, thank you, @maltrud!

@xylar xylar merged commit 9e258a3 into MPAS-Dev:master Nov 21, 2023
7 checks passed
@xylar xylar deleted the add-smooth-topo-tool branch November 21, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltrud maltrud maltrud approved these changes

Assignees

@xylar xylar

Labels
conda package enhancement ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xylar @maltrud