Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit lon to -180 to 180 in lon-lat region masks #547

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jan 8, 2024

This is needed for grids where longitude is from 0 to 360 and it is inconvenient to modify the grid before passing it to the command-line tool.

This is needed for grids where longitude is from 0 to 360 and it
is inconvenient to modify the grid before passing it to the
command-line tool.
@xylar xylar self-assigned this Jan 8, 2024
@xylar
Copy link
Collaborator Author

xylar commented Jan 8, 2024

We have been seeing missing SOSE data in T-S diagrams and I think this is the cause. See this example:
https://portal.nersc.gov/cfs/e3sm/xylar/analysis/E3SM-Arcticv2.1_historical0201_TS/Years1971-1990/ocean/index.html#tsDiagAntarcticRegions
Any region that only has data at negative longitudes is missing. (Regions that cross the antimeridian are probably showing only the data from positive longitudes.)

@xylar
Copy link
Collaborator Author

xylar commented Jan 12, 2024

Testing

I tested this as part of E3SM-Unified 1.9.2rc3. The results are as expected (that SOSE data is available in T-S diagrams at all longitudes):
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/test_e3sm_unified_1.9.2rc3_chrysalis/main_py3.10/ocean/index.html#tsDiagAntarcticRegions
Ignore the strange color scale -- this simulation is on a very coarse mesh.

@xylar xylar merged commit bcedec2 into MPAS-Dev:master Jan 12, 2024
7 checks passed
@xylar xylar deleted the fix-lon-lat-region-masks branch January 12, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant