Ignore NaNs when checking for negative basalHeatFlux #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore NaNs when checking for negative basalHeatFlux by using np.nanmin() instead of just min(). This will not throw an assertion error when NaNs are present in the interpolated basalHeatFlux field. NaNs in datasets are a separate issue from sign conventions, so will be dealt with separately.
This was referenced Jan 31, 2024
matthewhoffman
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Tested this in MPAS-Dev/compass#767 and the AIS mesh gen tests passed.
matthewhoffman
approved these changes
Jan 31, 2024
matthewhoffman
added a commit
to MPAS-Dev/compass
that referenced
this pull request
Jan 31, 2024
Update file names on LCRC server Update file names on LCRC server to use files that do not have negative basal heat flux. Note: The Antarctic data files still include NaNs as missing values. This requires the changes in MPAS-Dev/MPAS-Tools#551 to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore NaNs when checking for negative basalHeatFlux by using np.nanmin() instead of just min(). This will not throw an assertion error when NaNs are present in the interpolated basalHeatFlux field. NaNs in datasets are a separate issue from sign conventions, so will be dealt with separately. This merge fixes a bug introduced in #543.