Make some variables optional in MpasCellCuller.x #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
changed the title
meshDensity an optional variable in MpasCellCuller.x
xylar
force-pushed
the
fix-cell-culler
branch
from
bfe1357
to
d8e7d44
Compare
xylar
force-pushed
the
fix-cell-culler
branch
from
d8e7d44
to
4c4fae1
Compare
TestingI was able to successfully run the |
xylar
force-pushed
the
fix-cell-culler
branch
from
4c4fae1
to
20d1434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to run the cell culler even on meshes (e.g. in MPAS-Seaice restart files) without
meshDensity,weightsOnEdge, andangleEdgeas variables.I have made some updates to the configurations used to make local package builds and run CI so they match the package versions that conda-forge is using. I include this here because I used it in testing these changes.