-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to mask off frozen regions of hydro domain #562
Add script to mask off frozen regions of hydro domain #562
Conversation
Creates a new script, floodFillThawedIce.py, that deactivates frozen regions of the hydro domain by using a flood fill of thawed basal ice originating at the grounding line. Thickness of frozen ice is set to zero and a no-flow waterFluxMask is defined surrounding the frozen area.
@alexolinhager, if you want this to be available in the A final note that we typically use script names that are lowercase with underscores but I'll leave it up to @matthewhoffman how strict things are with the land ice scripts. |
Establishes UbThresh in floodFillThawedIce.py as an input variable with a default value of 25 m/yr
Thanks @xylar, right now we just want this to be a script we can refer to and will use occasionally, but that doesn't need to be part of the conda package. I'll change the name though to make sure it's consistent with the rest of MPAS-Tools |
Okay, sounds good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexolinhager , thanks for opening a PR for this script. It will be good to have this saved for future use. I have requested some changes. A few will change the result, so take a careful look at things after making the adjustments and make sure those suggestions make sense.
Makes minor edits to the PR in accordance with the first round of review that improve performance and clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexolinhager , thanks for the changes. I re-reviewed and just noticed one minor typo I made a suggestion for. Once you fix that and rename the script I can go ahead and merge this.
One other thing - can you comment on what impact the changes to the logic had? (changing growMask to use an or
of the two conditions; considering thawed regions only where BMB is negative rather than nonzero)
@matthewhoffman I made a few more changes to the script, mostly just minor debugging to allow the script to work with different input files that may have various variables in it that we want to get rid of. I did change back the calculation of The change from Based on the plots below though, I am confident the current script is doing what we want it to do. Non-zero thickness only exists in areas where basalMeltInput > 0, basalSlidingSpeed > 25 m/yr, and that are connected to the grounding line. Using the additional basalSlidingSpeed criteria allows us to capture the Whillans Ice Stream while having a minimal effect on the rest of the domain |
Fix typo in description Co-authored-by: Matt Hoffman <wyeast@gmail.com>
7a91efa
to
74de4ea
Compare
Fixes a few minor bugs in the script
74de4ea
to
baecc14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexolinhager, looks good, thanks for making the changes
Creates a new script, floodFillThawedIce.py, that deactivates frozen regions of the hydro domain by using a flood fill of thawed basal ice originating at the grounding line. Thickness of frozen ice is set to zero and a no-flow waterFluxMask is defined surrounding the frozen area.