Create a landice module for the mpas_tools conda package
#569
Conversation
Create a landice module for the mpas_tools conda package, and add a visualization submodule containing plot_transect().
|
Exciting! You also need to add an empty |
Add plot_map(), plot_grounding_line() and helper functions to mpas_tools.landice.visualization.
TestingCreating a map of Adding grounding lines from multiple files to a map of Creating maps of Transects down Thwaites Glacier from ISMIP6 expAE02 at 2200-2204 (I still need to work out coloring by time when using multiple input files for this one): Transects of geometry and temperature down Thwaites Glacier from ISMIP6 expAE02 at 2015, 2100, 2200, and 2300: Plot a map of a pre-computed field (here, thickness change between 2015 and 2300), along with grounding lines: |
Add ability to plot map of pre-computed field, rather than providing the name of a MALI variable. For example, you can calculate thickness change between two time levels or output files and pass that as the variable argument to landice.plot_map().
|
@xylar and @andrewdnolan, will either of you be able to review this soon? |
|
Sorry, I missed that it was ready for review. I think you need to also ping the reviewers again when you mark the PR as ready for review. I will be at FRISP most of next week so I'm not sure how soon I can review. |
|
@trhille, could you also add some documentation to https://github.com/MPAS-Dev/MPAS-Tools/tree/master/conda_package/docs and make sure it builds locally? https://mpas-dev.github.io/MPAS-Tools/stable/building_docs.html |
|
@xylar, I've added and built the documentation. Everything looks as expected. |
trhille
force-pushed
the
landice/add_landice_conda_package
branch
from
ceb9983
to
677346f
Compare
Use current data file instead of general mesh file to calculate grounding line masks.
Add norm argument to plot_map() and plot_grounding_lines(), which is helpful for customizing colorbars. For example, asymmetric and discrete colorbars require passing TwoSlopeNorm and BoundaryNorm, respectively.
|
@trhille, this looks good to me. @andrewdnolan, I'll count on you testing this to make sure it works for you. |
|
@andrewdnolan and @trhille, how is this coming along? I need to make a new MPAS-Tools release that includes #571 pretty soon. It would also be nice to have #567 in a release (since I promised to do that almost 2 months ago). |
|
Sorry about the delay with this! I will do some testing first thing on Monday morning and report back! |
Testing@trhille Sorry this look so long to review, but it's looking great! I've tested this on
|
|
Nice @trhille! Thanks for the review, @andrewdnolan! |
Create a
landicemodule for thempas_toolsconda package, and add avisualizationsubmodule containingplot_transect(),plot_map(),plot_grounding_lines(), and various helper functions.Note: Currently these tools are designed for fields defined on cells. Plotting fields on edges will require some changes.
Documentation can be found here: https://portal.nersc.gov/cfs/fanssie/trhille/mpas-tools-docs-landice_module/