Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how docs detects compass version #349

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Fix how docs detects compass version #349

merged 1 commit into from
Apr 1, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Apr 1, 2022

This got missed in #343

@xylar xylar self-assigned this Apr 1, 2022
@xylar xylar added bug Something isn't working documentation Improvements or additions to documentation python package DEPRECATED: PRs and Issues involving the python package (master branch) and removed python package DEPRECATED: PRs and Issues involving the python package (master branch) labels Apr 1, 2022
@xylar
Copy link
Collaborator Author

xylar commented Apr 1, 2022

Testing

With these changes, I'm able to build the docs locally whereas they fail without this change.

CI didn't catch this because it assigns the version number rather than trying to detect it.

@xylar xylar merged commit cd6b51d into MPAS-Dev:master Apr 1, 2022
@xylar xylar deleted the fix_docs branch April 1, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar