Automatically get cores_per_node on single node
#357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For non-HPC machines, it's typically fine to just detect the number of available cores.
|
@matthewhoffman, I don't think you need to do any testing of this. It is only useful on a Mac or Linux machine. I just wanted to flag you because I pulled this out of #353 for clarity. |
matthewhoffman
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
@xylar , thanks for flagging me. I glanced it over and it make sense. The one thing I looked for is that the docs explain how a user could specify this now that it's gone from the default cfg file (and, hence, a user might not realize this option exists). But you have that covered, so this looks good!
|
Thanks @matthewhoffman! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-HPC machines, it's typically fine to just detect the number of available cores.
This should reduce the amount of information needed in a user config file.